You can not select more than 25 topics
Topics must start with a letter or number, can include dashes ('-') and can be up to 35 characters long.
48 lines
1.6 KiB
48 lines
1.6 KiB
8 months ago
|
From 4fc5dafd1c8167a98e3a5f51efc1ea5092513364 Mon Sep 17 00:00:00 2001
|
||
|
|
From: rgirada <rgirada@vmware.com>
|
||
|
|
Date: Thu, 18 Feb 2021 20:15:40 -0800
|
||
|
|
Subject: [PATCH] lib: Routemap is not getting applied upon changing the
|
||
|
|
routemap action
|
||
|
|
|
||
|
|
Description:
|
||
|
|
This looks broken after NB changes in routemap. When routemap
|
||
|
|
action modified from permit to deny, it is expected to apply
|
||
|
|
the new action on the filtered routes before the action in the
|
||
|
|
routemap data structure has been changed. But currently this is
|
||
|
|
not handled by the corresponding northbound API.
|
||
|
|
|
||
|
|
Signed-off-by: Rajesh Girada <rgirada@vmware.com>
|
||
|
|
---
|
||
|
|
lib/routemap_northbound.c | 11 ++++++++++-
|
||
|
|
1 file changed, 10 insertions(+), 1 deletion(-)
|
||
|
|
|
||
|
|
diff --git a/lib/routemap_northbound.c b/lib/routemap_northbound.c
|
||
|
|
index db06e9caac75..3473ca2aea8c 100644
|
||
|
|
--- a/lib/routemap_northbound.c
|
||
|
|
+++ b/lib/routemap_northbound.c
|
||
|
|
@@ -271,6 +271,7 @@ lib_route_map_entry_description_destroy(struct nb_cb_destroy_args *args)
|
||
|
|
static int lib_route_map_entry_action_modify(struct nb_cb_modify_args *args)
|
||
|
|
{
|
||
|
|
struct route_map_index *rmi;
|
||
|
|
+ struct route_map *map;
|
||
|
|
|
||
|
|
switch (args->event) {
|
||
|
|
case NB_EV_VALIDATE:
|
||
|
|
@@ -281,7 +282,15 @@ static int lib_route_map_entry_action_modify(struct nb_cb_modify_args *args)
|
||
|
|
case NB_EV_APPLY:
|
||
|
|
rmi = nb_running_get_entry(args->dnode, NULL, true);
|
||
|
|
rmi->type = yang_dnode_get_enum(args->dnode, NULL);
|
||
|
|
- /* TODO: notify? */
|
||
|
|
+ map = rmi->map;
|
||
|
|
+
|
||
|
|
+ /* Execute event hook. */
|
||
|
|
+ if (route_map_master.event_hook) {
|
||
|
|
+ (*route_map_master.event_hook)(map->name);
|
||
|
|
+ route_map_notify_dependencies(map->name,
|
||
|
|
+ RMAP_EVENT_CALL_ADDED);
|
||
|
|
+ }
|
||
|
|
+
|
||
|
|
break;
|
||
|
|
}
|
||
|
|
|