facter

Commit Graph

Author	SHA1	Message	Date
Todd Zullinger	4b98da968b	Avoid warnings when virt-what produces no output The previous patch caused spurious warnings from facter when the virt-what command produced no output, as it would if run by root on a physical host: $ sudo facter virtual Could not retrieve virtual: private method `gsub' called for nil:NilClass physical Josh Cooper from Puppet Labs caught and fixed this.	12 years ago
Todd Zullinger	be66d28fa4	Apply upstream patch to filter virt-what warnings from virtual fact With the additional requirement of virt-what that was added in facter-1.6.18-1, the virtual fact was incorrect when facter was not run by root: $ facter \| egrep '^(facterversion\|virtual)' facterversion => 1.6.18 virtual => virt-what: this script must be run as root This is upstream ticket #19989¹. It was applied to the 1.7.x branch². ¹ https://projects.puppetlabs.com/issues/19989 ² https://github.com/puppetlabs/facter/commit/b7784a3	12 years ago

Author

SHA1

Message

Date

Todd Zullinger

4b98da968b

Avoid warnings when virt-what produces no output

The previous patch caused spurious warnings from facter when the
virt-what command produced no output, as it would if run by root on a
physical host:

$ sudo facter virtual
Could not retrieve virtual: private method `gsub' called for nil:NilClass
physical

Josh Cooper from Puppet Labs caught and fixed this.

Todd Zullinger

be66d28fa4

Apply upstream patch to filter virt-what warnings from virtual fact

With the additional requirement of virt-what that was added in
facter-1.6.18-1, the virtual fact was incorrect when facter was not run
by root:

$ facter | egrep '^(facterversion|virtual)'
facterversion => 1.6.18
virtual => virt-what: this script must be run as root

This is upstream ticket #19989¹.  It was applied to the 1.7.x branch².

¹ https://projects.puppetlabs.com/issues/19989
² https://github.com/puppetlabs/facter/commit/b7784a3

2 Commits (938d3cb881bac8ee26159f8c6d7d959704225dba)