You can not select more than 25 topics Topics must start with a letter or number, can include dashes ('-') and can be up to 35 characters long.
abrt/SOURCES/0067-shellcheck-Use-.-inste...

48 lines
1.7 KiB

From 9edffdf1a4be9a2983cb69f1ebff81c805cde72f Mon Sep 17 00:00:00 2001
From: Martin Kutlak <mkutlak@redhat.com>
Date: Wed, 12 Dec 2018 16:09:59 +0100
Subject: [PATCH] shellcheck: Use $(...) instead of legacy backticked
Fixes ShellCheck warning SC2006.
Signed-off-by: Martin Kutlak <mkutlak@redhat.com>
---
src/cli/abrt-console-notification.sh | 4 ++--
src/plugins/abrt-action-analyze-ccpp-local.in | 2 +-
2 files changed, 3 insertions(+), 3 deletions(-)
diff --git a/src/cli/abrt-console-notification.sh b/src/cli/abrt-console-notification.sh
index cd69eb38..c245677b 100755
--- a/src/cli/abrt-console-notification.sh
+++ b/src/cli/abrt-console-notification.sh
@@ -26,11 +26,11 @@ if [ ! -f "$LPATHDIR" ]; then
mkdir -p "$LPATHDIR" >"$ABRT_DEBUG_LOG" 2>&1 || return 0
fi
-TMPPATH=`mktemp --tmpdir="$LPATHDIR" lastnotification.XXXXXXXX 2> "$ABRT_DEBUG_LOG"`
+TMPPATH=$(mktemp --tmpdir="$LPATHDIR" lastnotification.XXXXXXXX 2> "$ABRT_DEBUG_LOG")
SINCE=0
if [ -f "$SINCEFILE" ]; then
- SINCE=`cat $SINCEFILE 2>"$ABRT_DEBUG_LOG"`
+ SINCE=$(cat "$SINCEFILE" 2>"$ABRT_DEBUG_LOG")
fi
# always update the lastnotification
diff --git a/src/plugins/abrt-action-analyze-ccpp-local.in b/src/plugins/abrt-action-analyze-ccpp-local.in
index 6691c59b..92593437 100644
--- a/src/plugins/abrt-action-analyze-ccpp-local.in
+++ b/src/plugins/abrt-action-analyze-ccpp-local.in
@@ -15,7 +15,7 @@ if $INSTALL_DI; then
# debuginfo install fail even for root.
# Therefore, if we are root, we don't use the wrapper.
EXECUTABLE=@LIBEXEC_DIR@/abrt-action-install-debuginfo-to-abrt-cache
- if [ x"`id -u`" = x"0" ]; then
+ if [ x"$(id -u)" = x"0" ]; then
EXECUTABLE=abrt-action-install-debuginfo
fi
--
2.26.2