You can not select more than 25 topics Topics must start with a letter or number, can include dashes ('-') and can be up to 35 characters long.
NetworkManager-openvpn/0002-properties-fix-validat...

34 lines
1.2 KiB

From eae01ceaeed9bf2c46a3b402fef89024dde0853b Mon Sep 17 00:00:00 2001
From: Brandon Guttersohn <bguttersohn@gmail.com>
Date: Wed, 27 Sep 2017 09:57:58 +0200
Subject: [PATCH 1/1] properties: fix validation of static-key in GUI
Otherwise it's not possible to edit a connection with static key.
[thaller@redhat.com: modified original patch and add commit message]
https://bugzilla.gnome.org/show_bug.cgi?id=788226
Fixes: 86a70095afc229f1f970b7e546390d166152cfc2
(cherry picked from commit b83f028a6da067dcc9b31555c15411f0288ebda1)
---
properties/auth-helpers.c | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)
diff --git a/properties/auth-helpers.c b/properties/auth-helpers.c
index c55afd1..16ff6e5 100644
--- a/properties/auth-helpers.c
+++ b/properties/auth-helpers.c
@@ -449,7 +449,7 @@ auth_widget_check_validity (GtkBuilder *builder, const char *contype, GError **e
} else if (!strcmp (contype, NM_OPENVPN_CONTYPE_STATIC_KEY)) {
widget = GTK_WIDGET (gtk_builder_get_object (builder, "sk_key_chooser"));
filename = gtk_file_chooser_get_filename (GTK_FILE_CHOOSER (widget));
- if (filename && strlen (filename)) {
+ if (!filename || !filename[0]) {
g_free (filename);
g_set_error (error,
NMV_EDITOR_PLUGIN_ERROR,
--
2.13.5